Skip to content

fix: Update children's states to ready even if some children are not ready (fixes #147). #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Update children's states to ready even if some children are not ready (fixes #147). #148

wants to merge 1 commit into from

Conversation

@sitaowang1998
Copy link
Collaborator

@sitaowang1998 sitaowang1998 commented May 29, 2025 •
edited
Loading

Description

MySQL task_finish implementation only updates children's state to ready if all children are ready. This pr fixes the problem by updating the states of ready children and leave non-ready children's state as pending.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

  • GitHub workflows pass.
  • Unit tests pass in dev container.
  • Integration tests pass in dev container.

Summary by CodeRabbit

  • Bug Fixes
    • Improved task status updates to ensure tasks only move to the 'ready' state when all required inputs are available.

@sitaowang1998 sitaowang1998 requested a review from a team as a code owner May 29, 2025 18:24
@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 29, 2025 •
edited
Loading

Walkthrough

The SQL update query in the MySqlMetadataStorage::task_finish method was revised, replacing a NOT EXISTS subquery with a NOT IN clause for determining which dependent tasks should be set to 'ready' state. No changes were made to function signatures or exported entities.

Changes

File(s) Change Summary
src/spider/storage/mysql/MySqlStorage.cpp Modified the SQL query in task_finish to use NOT IN instead of NOT EXISTS for task readiness logic.

Sequence Diagram(s)

sequenceDiagram
    participant MySqlMetadataStorage
    participant MySQL DB

    MySqlMetadataStorage->>MySQL DB: Update tasks to 'ready' where dependencies are met (using NOT IN)
    MySQL DB-->>MySqlMetadataStorage: Acknowledge updated rows
Loading

Possibly related issues

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 29, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/spider/storage/mysql/MySqlStorage.cpp (1)

1641-1646: SQL query logic is correct but consider NULL handling with NOT IN.

The modified query correctly implements the intended behaviour to update only those dependent tasks to 'ready' state that have all their inputs available, while leaving tasks with missing inputs in 'pending' state. This aligns well with the PR objective.

However, be aware that NOT IN can behave unexpectedly if the subquery returns any NULL values - the entire NOT IN expression would evaluate to UNKNOWN for all rows. Since task_id is likely a non-null primary/foreign key, this shouldn't be an issue here, but it's worth noting for future SQL modifications.

Consider adding a comment explaining the complex nested subquery logic for future maintainability:

        // Set task states to ready if all inputs are available
+        // Update dependent tasks to ready state, excluding those with missing inputs
        std::unique_ptr<sql::PreparedStatement> ready_statement(
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6b7e5ff and c4f055e.

📒 Files selected for processing (1)
  • src/spider/storage/mysql/MySqlStorage.cpp (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: lint
  • GitHub Check: non-storage-unit-tests (ubuntu-22.04)
  • GitHub Check: non-storage-unit-tests (ubuntu-24.04)

@sitaowang1998 sitaowang1998 requested a review from davidlion May 29, 2025 18:29
@sitaowang1998 sitaowang1998 changed the title fix: Updates children's states to ready even if some children are not ready (fixes #147). fix: Update children's states to ready even if some children are not ready (fixes #147). May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@davidlion davidlion Awaiting requested review from davidlion

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sitaowang1998